Force emission of const return functions using new API #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/jlgen.jl b/src/jlgen.jl
index 6dd691e..e0e9383 100644
--- a/src/jlgen.jl
+++ b/src/jlgen.jl
@@ -625,7 +625,7 @@ function compile_method_instance(@nospecialize(job::CompilerJob))
cgparams = (; lookup = Base.unsafe_convert(Ptr{Nothing}, lookup_cb), cgparams... )
end
if VERSION > v"1.13.0-DEV.285"
- cgparams = (; force_emit_all = true , cgparams...)
+ cgparams = (; force_emit_all = true, cgparams...)
end
params = Base.CodegenParams(; cgparams...)
|
|
Still some nightly issues, but much better. Thanks @gbaraldi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on JuliaLang/julia#57824 being merged to add a correct version check